Skip to content

Expose git add to CLI and remove add_all= True as default from repo.commit()#116

Merged
hannahlanzrath merged 5 commits intomainfrom
feat/expose_git_add_to_cli
Feb 25, 2026
Merged

Expose git add to CLI and remove add_all= True as default from repo.commit()#116
hannahlanzrath merged 5 commits intomainfrom
feat/expose_git_add_to_cli

Conversation

@hannahlanzrath
Copy link
Contributor

This PR seeks to harmonize CADET-RDM further with the Git Interface, by exposing git add via rdm add, giving the possibility to stage single files instead of adding all with the commit. Secondly, the default setting of add_all=True for the Python interface method repo.commit() is changed to False, and the arguments removed from internal function calls respectively. Finanlly, the documentation is updated to make the use of these commands clearer and reflect those changes.

@hannahlanzrath hannahlanzrath force-pushed the feat/expose_git_add_to_cli branch from d19654a to 43541b6 Compare February 12, 2026 13:43
@hannahlanzrath hannahlanzrath force-pushed the feat/expose_git_add_to_cli branch 2 times, most recently from 93657b6 to 9866032 Compare February 19, 2026 08:19

```bash
rdm commit -m <message>
rdm add -f <filepath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the -f flag necessary or is it possible to simply write

rdm add foo.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the input from option to argument, which makes the filepath required and allows using it as you wrote :)

create_output_readme()

repo = OutputRepo(".")
repo.add_all_files()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of a dedicated method, would it be possible to instead use a flag for the regular add method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is also possible, I switched to setting add_all=True in the commit here instead

Copy link
Contributor

@schmoelder schmoelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some comments

@hannahlanzrath hannahlanzrath force-pushed the feat/expose_git_add_to_cli branch 5 times, most recently from 350db50 to 4803248 Compare February 25, 2026 14:48
@hannahlanzrath hannahlanzrath force-pushed the feat/expose_git_add_to_cli branch from 4803248 to 62ae9ff Compare February 25, 2026 14:53
@hannahlanzrath hannahlanzrath merged commit d312820 into main Feb 25, 2026
5 checks passed
@hannahlanzrath hannahlanzrath deleted the feat/expose_git_add_to_cli branch February 25, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants