Expose git add to CLI and remove add_all= True as default from repo.commit()#116
Merged
hannahlanzrath merged 5 commits intomainfrom Feb 25, 2026
Merged
Expose git add to CLI and remove add_all= True as default from repo.commit()#116hannahlanzrath merged 5 commits intomainfrom
hannahlanzrath merged 5 commits intomainfrom
Conversation
d19654a to
43541b6
Compare
93657b6 to
9866032
Compare
schmoelder
reviewed
Feb 19, 2026
|
|
||
| ```bash | ||
| rdm commit -m <message> | ||
| rdm add -f <filepath> |
Contributor
There was a problem hiding this comment.
Is the -f flag necessary or is it possible to simply write
rdm add foo.py
Contributor
Author
There was a problem hiding this comment.
I changed the input from option to argument, which makes the filepath required and allows using it as you wrote :)
schmoelder
reviewed
Feb 19, 2026
cadetrdm/initialize_repo.py
Outdated
| create_output_readme() | ||
|
|
||
| repo = OutputRepo(".") | ||
| repo.add_all_files() |
Contributor
There was a problem hiding this comment.
instead of a dedicated method, would it be possible to instead use a flag for the regular add method?
Contributor
Author
There was a problem hiding this comment.
That is also possible, I switched to setting add_all=True in the commit here instead
350db50 to
4803248
Compare
This commit exposes the git add function to the CLI via "rdm add" which allows specifying files to be staged.
…om internal function calls
…l add_all flag in PI documentation
4803248 to
62ae9ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to harmonize CADET-RDM further with the Git Interface, by exposing
git addviardm add, giving the possibility to stage single files instead of adding all with the commit. Secondly, the default setting ofadd_all=Truefor the Python interface methodrepo.commit()is changed toFalse, and the arguments removed from internal function calls respectively. Finanlly, the documentation is updated to make the use of these commands clearer and reflect those changes.